Fix potential crash in QStyleAnimation::updateCurrentTime()

A parentless/targetless QStyleAnimation calls updateCurrentTime() from
QAbstractAnimation constructor. Avoid the potential crash even if it's
not a valid use case for QStyleAnimation.

Change-Id: I9cd263d105c8ea4b5cbabac9a7680991745ccd95
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>

diff --git a/src/widgets/styles/qstyleanimation.cpp b/src/widgets/styles/qstyleanimation.cpp
index 297a929..6173dc9 100644 (file)
--- a/src/widgets/styles/qstyleanimation.cpp
+++ b/src/widgets/styles/qstyleanimation.cpp
@@ -83,15 +83,17 @@ bool QStyleAnimation::isUpdateNeeded() const
 
 void QStyleAnimation::updateCurrentTime(int)
 {
-    if (target()->isWidgetType()) {
-        QWidget *widget = static_cast<QWidget *>(target());
-        if (!widget->isVisible() || widget->window()->isMinimized())
-            stop();
-    }
-
-    if (isUpdateNeeded()) {
-        QEvent event(QEvent::StyleAnimationUpdate);
-        QCoreApplication::sendEvent(target(), &event);
+    if (QObject *tgt = target()) {
+        if (tgt->isWidgetType()) {
+            QWidget *widget = static_cast<QWidget *>(tgt);
+            if (!widget->isVisible() || widget->window()->isMinimized())
+                stop();
+        }
+
+        if (isUpdateNeeded()) {
+            QEvent event(QEvent::StyleAnimationUpdate);
+            QCoreApplication::sendEvent(tgt, &event);
+        }
     }
 }