accel/habanalabs: change COMMS warning messages to error level
authorKoby Elbaz <kelbaz@habana.ai>
Tue, 21 Mar 2023 14:03:07 +0000 (16:03 +0200)
committerOded Gabbay <ogabbay@kernel.org>
Sat, 8 Apr 2023 07:39:33 +0000 (10:39 +0300)
COMMS protocol is used for LKD <--> FW communication, and any
communication failure between the two might turn out to be
destructive, hence, it should be well emphasized.

Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
drivers/accel/habanalabs/common/firmware_if.c

index 7ea6113..96027a1 100644 (file)
@@ -1263,7 +1263,7 @@ void hl_fw_ask_hard_reset_without_linux(struct hl_device *hdev)
                                COMMS_RST_DEV, 0, false,
                                hdev->fw_loader.cpu_timeout);
                if (rc)
-                       dev_warn(hdev->dev, "Failed sending COMMS_RST_DEV\n");
+                       dev_err(hdev->dev, "Failed sending COMMS_RST_DEV\n");
        } else {
                WREG32(static_loader->kmd_msg_to_cpu_reg, KMD_MSG_RST_DEV);
        }
@@ -1284,7 +1284,7 @@ void hl_fw_ask_halt_machine_without_linux(struct hl_device *hdev)
                                COMMS_GOTO_WFE, 0, true,
                                hdev->fw_loader.cpu_timeout);
                if (rc)
-                       dev_warn(hdev->dev, "Failed sending COMMS_GOTO_WFE\n");
+                       dev_err(hdev->dev, "Failed sending COMMS_GOTO_WFE\n");
        } else {
                WREG32(static_loader->kmd_msg_to_cpu_reg, KMD_MSG_GOTO_WFE);
                msleep(static_loader->cpu_reset_wait_msec);