EDAC, altera: Fix an error handling path in altr_s10_sdram_probe()

If regmap_write() fails, we should release some resources as done in all
the other error handling paths of the function.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Thor Thayer <thor.thayer@linux.intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20180610174532.22071-1-christophe.jaillet@wanadoo.fr
Fixes: e9918d7fafae ("EDAC, altera: Handle SDRAM Uncorrectable Errors on Stratix10")
Signed-off-by: Borislav Petkov <bp@suse.de>

diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index d0d5c4d..5762c3c 100644 (file)
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -730,7 +730,8 @@ static int altr_s10_sdram_probe(struct platform_device *pdev)
                         S10_DDR0_IRQ_MASK)) {
                edac_printk(KERN_ERR, EDAC_MC,
                            "Error clearing SDRAM ECC count\n");
-               return -ENODEV;
+               ret = -ENODEV;
+               goto err2;
        }
 
        if (regmap_update_bits(drvdata->mc_vbase, priv->ecc_irq_en_offset,