COFF: Remove a function that doesn't do much itself. NFC.

llvm-svn: 240901

diff --git a/lld/COFF/Driver.cpp b/lld/COFF/Driver.cpp
index 694f99f..634b63c 100644 (file)
--- a/lld/COFF/Driver.cpp
+++ b/lld/COFF/Driver.cpp
@@ -233,7 +233,7 @@ bool LinkerDriver::link(llvm::ArrayRef<const char *> ArgsArr) {
     return llvm::libDriverMain(ArgsArr.slice(1)) == 0;
 
   // Parse command line options.
-  auto ArgsOrErr = Parser.parseLINK(ArgsArr);
+  auto ArgsOrErr = Parser.parseLINK(ArgsArr.slice(1));
   if (auto EC = ArgsOrErr.getError()) {
     llvm::errs() << EC.message() << "\n";
     return false;

diff --git a/lld/COFF/Driver.h b/lld/COFF/Driver.h
index 43e8005..509edb7 100644 (file)
--- a/lld/COFF/Driver.h
+++ b/lld/COFF/Driver.h
@@ -53,7 +53,6 @@ public:
   }
 
 private:
-  ErrorOr<llvm::opt::InputArgList> parse(std::vector<const char *> Argv);
   std::vector<const char *> tokenize(StringRef S);
 
   ErrorOr<std::vector<const char *>>

diff --git a/lld/COFF/DriverUtils.cpp b/lld/COFF/DriverUtils.cpp
index 464afb2..6859e40 100644 (file)
--- a/lld/COFF/DriverUtils.cpp
+++ b/lld/COFF/DriverUtils.cpp
@@ -542,15 +542,15 @@ public:
 
 // Parses a given list of options.
 ErrorOr<llvm::opt::InputArgList>
-ArgParser::parse(std::vector<const char *> Argv) {
+ArgParser::parse(ArrayRef<const char *> ArgsArr) {
   // First, replace respnose files (@<file>-style options).
-  auto ArgvOrErr = replaceResponseFiles(Argv);
+  auto ArgvOrErr = replaceResponseFiles(ArgsArr);
   if (auto EC = ArgvOrErr.getError()) {
     llvm::errs() << "error while reading response file: " << EC.message()
                  << "\n";
     return EC;
   }
-  Argv = std::move(ArgvOrErr.get());
+  std::vector<const char *> Argv = std::move(ArgvOrErr.get());
 
   // Make InputArgList from string vectors.
   COFFOptTable Table;
@@ -571,20 +571,13 @@ ArgParser::parse(std::vector<const char *> Argv) {
 }
 
 ErrorOr<llvm::opt::InputArgList>
-ArgParser::parse(llvm::ArrayRef<const char *> Args) {
-  Args = Args.slice(1);
-  std::vector<const char *> V(Args.begin(), Args.end());
-  return parse(V);
-}
-
-ErrorOr<llvm::opt::InputArgList>
 ArgParser::parseLINK(ArrayRef<const char *> Args) {
   // Concatenate LINK env and given arguments and parse them.
   Optional<std::string> Env = Process::GetEnv("LINK");
   if (!Env)
     return parse(Args);
   std::vector<const char *> V = tokenize(*Env);
-  V.insert(V.end(), Args.begin() + 1, Args.end());
+  V.insert(V.end(), Args.begin(), Args.end());
   return parse(V);
 }