pinctrl: baytrail: Use BIT() in BYT_PULL_ASSIGN_* definitions
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 2 Jun 2023 16:56:15 +0000 (19:56 +0300)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 2 Jun 2023 17:34:53 +0000 (20:34 +0300)
The bias setting (pull-up or pull-down) are bit fields and
we never enable them both, hence use BIT() macro to define
them.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/pinctrl/intel/pinctrl-baytrail.c

index 9a11e9f..4e336b7 100644 (file)
 #define BYT_PULL_STR_10K       (1 << BYT_PULL_STR_SHIFT)
 #define BYT_PULL_STR_20K       (2 << BYT_PULL_STR_SHIFT)
 #define BYT_PULL_STR_40K       (3 << BYT_PULL_STR_SHIFT)
-#define BYT_PULL_ASSIGN_SHIFT  7
 #define BYT_PULL_ASSIGN_MASK   GENMASK(8, 7)
-#define BYT_PULL_ASSIGN_UP     (1 << BYT_PULL_ASSIGN_SHIFT)
-#define BYT_PULL_ASSIGN_DOWN   (2 << BYT_PULL_ASSIGN_SHIFT)
+#define BYT_PULL_ASSIGN_DOWN   BIT(8)
+#define BYT_PULL_ASSIGN_UP     BIT(7)
 #define BYT_PIN_MUX            GENMASK(2, 0)
 
 /* BYT_VAL_REG register bits */