rtlwifi: Replace hardcode value with macro
authorSouptick Joarder <jrdr.linux@gmail.com>
Wed, 2 Aug 2017 12:29:15 +0000 (17:59 +0530)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 3 Aug 2017 10:20:43 +0000 (13:20 +0300)
In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
and hw->max_rate_tries are replaced by macro and removed the comment.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtlwifi/base.c
drivers/net/wireless/realtek/rtlwifi/base.h

index 8b833e2..ea18aa7 100644 (file)
@@ -426,9 +426,8 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
        hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;
 
        /* TODO: Correct this value for our hw */
-       /* TODO: define these hard code value */
-       hw->max_listen_interval = 10;
-       hw->max_rate_tries = 4;
+       hw->max_listen_interval = MAX_LISTEN_INTERVAL;
+       hw->max_rate_tries = MAX_RATE_TRIES;
        /* hw->max_rates = 1; */
        hw->sta_data_size = sizeof(struct rtl_sta_info);
 
index ab7d819..b56d1b7 100644 (file)
@@ -65,6 +65,8 @@ enum ap_peer {
 #define FRAME_OFFSET_ADDRESS3          16
 #define FRAME_OFFSET_SEQUENCE          22
 #define FRAME_OFFSET_ADDRESS4          24
+#define MAX_LISTEN_INTERVAL            10
+#define MAX_RATE_TRIES                 4
 
 #define SET_80211_HDR_FRAME_CONTROL(_hdr, _val)                \
        WRITEEF2BYTE(_hdr, _val)