Introduce hook for text cursor changes in QTextEdit and QPlainTextEdit

Currently it is hard for Q{Plain}TextEdit subclasses to keep track
of changes of the text cursor by direct calls to setTextCursor from
arbitrary code. By redirecting the setTextCursor to a virtual
function subclasses get the chance to intercept such calls.

Change-Id: Id92d9c86928b97285b0f5b7b39790442dfac3e50
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>

diff --git a/src/widgets/widgets/qplaintextedit.cpp b/src/widgets/widgets/qplaintextedit.cpp
index 423f9b3..a5e9e0d 100644 (file)
--- a/src/widgets/widgets/qplaintextedit.cpp
+++ b/src/widgets/widgets/qplaintextedit.cpp
@@ -1314,6 +1314,17 @@ QTextDocument *QPlainTextEdit::document() const
 */
 void QPlainTextEdit::setTextCursor(const QTextCursor &cursor)
 {
+    doSetTextCursor(cursor);
+}
+
+/*!
+    \internal
+
+     This provides a hook for subclasses to intercept cursor changes.
+*/
+
+void QPlainTextEdit::doSetTextCursor(const QTextCursor &cursor)
+{
     Q_D(QPlainTextEdit);
     d->control->setTextCursor(cursor);
 }

diff --git a/src/widgets/widgets/qplaintextedit.h b/src/widgets/widgets/qplaintextedit.h
index b7395d3..628e4a8 100644 (file)
--- a/src/widgets/widgets/qplaintextedit.h
+++ b/src/widgets/widgets/qplaintextedit.h
@@ -254,6 +254,7 @@ protected:
     QPlainTextEdit(QPlainTextEditPrivate &dd, QWidget *parent);
 
     virtual void scrollContentsBy(int dx, int dy);
+    virtual void doSetTextCursor(const QTextCursor &cursor);
 
     QTextBlock firstVisibleBlock() const;
     QPointF contentOffset() const;

diff --git a/src/widgets/widgets/qtextedit.cpp b/src/widgets/widgets/qtextedit.cpp
index 0ab76db..0b31c53 100644 (file)
--- a/src/widgets/widgets/qtextedit.cpp
+++ b/src/widgets/widgets/qtextedit.cpp
@@ -757,6 +757,17 @@ QTextDocument *QTextEdit::document() const
 */
 void QTextEdit::setTextCursor(const QTextCursor &cursor)
 {
+    doSetTextCursor(cursor);
+}
+
+/*!
+    \internal
+
+     This provides a hook for subclasses to intercept cursor changes.
+*/
+
+void QTextEdit::doSetTextCursor(const QTextCursor &cursor)
+{
     Q_D(QTextEdit);
     d->control->setTextCursor(cursor);
 }

diff --git a/src/widgets/widgets/qtextedit.h b/src/widgets/widgets/qtextedit.h
index ab0a5ae..e2c294c 100644 (file)
--- a/src/widgets/widgets/qtextedit.h
+++ b/src/widgets/widgets/qtextedit.h
@@ -296,7 +296,7 @@ protected:
     QTextEdit(QTextEditPrivate &dd, QWidget *parent);
 
     virtual void scrollContentsBy(int dx, int dy);
-
+    virtual void doSetTextCursor(const QTextCursor &cursor);
 
 private:
     Q_DISABLE_COPY(QTextEdit)