MIPS: CPC: Use bitfield helpers
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 22 Nov 2021 15:53:46 +0000 (16:53 +0100)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Mon, 29 Nov 2021 11:42:57 +0000 (12:42 +0100)
Use the FIELD_PREP() helper, instead of open-coding the same operation.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/kernel/mips-cpc.c

index 8d25351..17aff13 100644 (file)
@@ -4,6 +4,7 @@
  * Author: Paul Burton <paul.burton@mips.com>
  */
 
+#include <linux/bitfield.h>
 #include <linux/errno.h>
 #include <linux/percpu.h>
 #include <linux/of.h>
@@ -97,7 +98,7 @@ void mips_cpc_lock_other(unsigned int core)
        curr_core = cpu_core(&current_cpu_data);
        spin_lock_irqsave(&per_cpu(cpc_core_lock, curr_core),
                          per_cpu(cpc_core_lock_flags, curr_core));
-       write_cpc_cl_other(core << __ffs(CPC_Cx_OTHER_CORENUM));
+       write_cpc_cl_other(FIELD_PREP(CPC_Cx_OTHER_CORENUM, core));
 
        /*
         * Ensure the core-other region reflects the appropriate core &