fs/ntfs3: Make mount option nohidden more universal
authorKari Argillander <kari.argillander@gmail.com>
Tue, 7 Sep 2021 15:35:54 +0000 (18:35 +0300)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Thu, 9 Sep 2021 16:28:53 +0000 (19:28 +0300)
If we call Opt_nohidden with just keyword hidden, then we can use
hidden/nohidden when mounting. We already use this method for almoust
all other parameters so it is just logical that this will use same
method.

Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/super.c

index 420cd14..729ead6 100644 (file)
@@ -242,7 +242,7 @@ static const struct fs_parameter_spec ntfs_fs_parameters[] = {
        fsparam_flag_no("discard",              Opt_discard),
        fsparam_flag_no("force",                Opt_force),
        fsparam_flag_no("sparse",               Opt_sparse),
-       fsparam_flag("nohidden",                Opt_nohidden),
+       fsparam_flag_no("hidden",               Opt_nohidden),
        fsparam_flag_no("acl",                  Opt_acl),
        fsparam_flag_no("showmeta",             Opt_showmeta),
        fsparam_string("nls",                   Opt_nls),
@@ -331,7 +331,7 @@ static int ntfs_fs_parse_param(struct fs_context *fc,
                opts->sparse = result.negated ? 0 : 1;
                break;
        case Opt_nohidden:
-               opts->nohidden = 1;
+               opts->nohidden = result.negated ? 1 : 0;
                break;
        case Opt_acl:
                if (!result.negated)