Add null check before strdup() 73/223373/1
authorYunjin Lee <yunjin-.lee@samsung.com>
Wed, 29 Jan 2020 06:33:50 +0000 (15:33 +0900)
committerYunjin Lee <yunjin-.lee@samsung.com>
Wed, 29 Jan 2020 06:33:50 +0000 (15:33 +0900)
Change-Id: I9779bb2ef4f827b591edb0d5226354cdc6fbbe8b
Signed-off-by: Yunjin Lee <yunjin-.lee@samsung.com>
capi/src/privilege_info.c

index be6417b043ec575e34cde4ce6a2e8a291870d3e9..df440e77c892d4a0532641af2615f788982d1d27 100755 (executable)
@@ -286,7 +286,7 @@ int privilege_info_get_privilege_group_display_name(const char *privilege_group,
        ret = privilege_info_get_group_name_string_id(privilege_group, &name_string_id);
 
        if (name_string_id == NULL) {
-               char *tempPrivilegeGroup = NULL;;
+               char *tempPrivilegeGroup = NULL;
                char *temp = NULL;
                char *buffer = NULL;
                char *save = NULL;
@@ -299,6 +299,7 @@ int privilege_info_get_privilege_group_display_name(const char *privilege_group,
                        buffer = temp;
                        temp = strtok_r(NULL, "/", &save);
                }
+               TryReturn(buffer != NULL, free(tempPrivilegeGroup), PRVMGR_ERR_INVALID_PARAMETER, "[PRVMGR_ERR_INVALID_PARAMETER] invalid privilege group <%s>", privilege_group);
                *name = strdup(buffer);
                TryReturn(*name != NULL, free(tempPrivilegeGroup), PRVMGR_ERR_OUT_OF_MEMORY, "[PRVMGR_ERR_OUT_OF_MEMORY] Memory allocation failed.");
                free(tempPrivilegeGroup);