can: bittiming: can_fixup_bittiming(): use CAN_SYNC_SEG instead of 1
authorMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 31 Jan 2023 16:37:39 +0000 (17:37 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 6 Feb 2023 12:57:25 +0000 (13:57 +0100)
Commit 1c47fa6b31c2 ("can: dev: add a helper function to calculate the
duration of one bit") made the constant CAN_SYNC_SEG available in a
header file.

The magic number 1 in can_fixup_bittiming() represents the width of
the sync segment, replace it by CAN_SYNC_SEG to make the code more
readable.

Link: https://lore.kernel.org/all/20230202110854.2318594-3-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/dev/bittiming.c

index 32af609..5e111db 100644 (file)
@@ -39,7 +39,7 @@ static int can_fixup_bittiming(const struct net_device *dev, struct can_bittimin
                return -EINVAL;
 
        bt->bitrate = priv->clock.freq / (bt->brp * can_bit_time(bt));
-       bt->sample_point = ((tseg1 + 1) * 1000) / can_bit_time(bt);
+       bt->sample_point = ((CAN_SYNC_SEG + tseg1) * 1000) / can_bit_time(bt);
 
        return 0;
 }