media: staging: atomisp: Remove unnecessary 'fallthrough'
authorCengiz Can <cengiz@kernel.wtf>
Mon, 31 Aug 2020 13:51:04 +0000 (15:51 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 22 Sep 2020 08:04:04 +0000 (10:04 +0200)
commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from
Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments
with 'fallthrough' pseudo-keyword.

However, in one of the switch-case statements, Coverity Static Analyzer
throws a warning that 'fallthrough' is unreachable due to the adjacent
'return false' statement. (Coverity ID CID 1466511)

In order to fix the unreachable code warning, remove unnecessary
fallthrough keyword.

Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_compat_css20.c

index a78c532..28796ec 100644 (file)
@@ -700,7 +700,6 @@ static bool is_pipe_valid_to_current_run_mode(struct atomisp_sub_device *asd,
                        return true;
 
                return false;
-               fallthrough;
        case ATOMISP_RUN_MODE_VIDEO:
                if (!asd->continuous_mode->val) {
                        if (pipe_id == IA_CSS_PIPE_ID_VIDEO ||