wifi: libertas_tf: don't call kfree_skb() under spin_lock_irqsave()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 7 Dec 2022 15:00:05 +0000 (23:00 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:32:50 +0000 (09:32 +0100)
[ Upstream commit 9388ce97b98216833c969191ee6df61a7201d797 ]

It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled. So replace kfree_skb()
with dev_kfree_skb_irq() under spin_lock_irqsave(). Compile
tested only.

Fixes: fc75122fabb5 ("libertas_tf: use irqsave() in USB's complete callback")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221207150008.111743-2-yangyingliang@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/marvell/libertas_tf/if_usb.c

index 75b5319d033f33577c9813a55973bf3cd325b5ed..1750f5e93de210a96706eec840ef78f796213886 100644 (file)
@@ -613,7 +613,7 @@ static inline void process_cmdrequest(int recvlength, uint8_t *recvbuff,
        spin_lock_irqsave(&priv->driver_lock, flags);
        memcpy(priv->cmd_resp_buff, recvbuff + MESSAGE_HEADER_LEN,
               recvlength - MESSAGE_HEADER_LEN);
-       kfree_skb(skb);
+       dev_kfree_skb_irq(skb);
        lbtf_cmd_response_rx(priv);
        spin_unlock_irqrestore(&priv->driver_lock, flags);
 }