pixmap: Add QPlatformPixmap::fromData null check for the image
authorHolger Hans Peter Freyther <holger@moiji-mobile.com>
Mon, 23 Jan 2012 13:02:48 +0000 (14:02 +0100)
committerQt by Nokia <qt-info@nokia.com>
Thu, 2 Feb 2012 00:56:03 +0000 (01:56 +0100)
QPlatformPixmap::fromFile is doing the null check,
QRasterPlatformPixmap::fromData is doing the null check as
well. Add the null check to QPlatformPixmap::fromData as
well. This would have avoided a crash in the directfb plugin.

Change-Id: Ifc904b2df2424e86bf0992d4e28dc256530be02d
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
src/gui/image/qplatformpixmap.cpp

index c34b779..5162ea8 100644 (file)
@@ -133,6 +133,8 @@ bool QPlatformPixmap::fromData(const uchar *buf, uint len, const char *format, Q
     QBuffer b(&a);
     b.open(QIODevice::ReadOnly);
     QImage image = QImageReader(&b, format).read();
+    if (image.isNull())
+        return false;
     fromImage(makeBitmapCompliantIfNeeded(this, image, flags), flags);
     return !isNull();
 }