io_uring: pin ctx on fallback execution
authorPavel Begunkov <asml.silence@gmail.com>
Tue, 17 Aug 2021 21:36:44 +0000 (22:36 +0100)
committerJens Axboe <axboe@kernel.dk>
Tue, 17 Aug 2021 22:06:14 +0000 (16:06 -0600)
Pin ring in io_fallback_req_func() by briefly elevating ctx->refs in
case any task_work handler touches ctx after releasing a request.

Fixes: 9011bf9a13e3b ("io_uring: fix stuck fallback reqs")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/833a494713d235ec144284a9bbfe418df4f6b61c.1629235576.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index 6a092a534d2b51351717e693f0ab4ab37058ddcd..979941bcd15a73bd358e848884bdc20fcacb099e 100644 (file)
@@ -2477,8 +2477,10 @@ static void io_fallback_req_func(struct work_struct *work)
        struct llist_node *node = llist_del_all(&ctx->fallback_llist);
        struct io_kiocb *req, *tmp;
 
+       percpu_ref_get(&ctx->refs);
        llist_for_each_entry_safe(req, tmp, node, io_task_work.fallback_node)
                req->io_task_work.func(req);
+       percpu_ref_put(&ctx->refs);
 }
 
 static void __io_complete_rw(struct io_kiocb *req, long res, long res2,