clocksource/drivers/timer-ti-dm: Fix missing clk_disable_unprepare in dmtimer_systime...
authorYang Yingliang <yangyingliang@huawei.com>
Sat, 29 Oct 2022 11:44:27 +0000 (19:44 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:14:04 +0000 (13:14 +0100)
[ Upstream commit 180d35a7c05d520314a590c99ad8643d0213f28b ]

If clk_get_rate() fails which is called after clk_prepare_enable(),
clk_disable_unprepare() need be called in error path to disable the
clock in dmtimer_systimer_init_clock().

Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20221029114427.946520-1-yangyingliang@huawei.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clocksource/timer-ti-dm-systimer.c

index 2737407..632523c 100644 (file)
@@ -345,8 +345,10 @@ static int __init dmtimer_systimer_init_clock(struct dmtimer_systimer *t,
                return error;
 
        r = clk_get_rate(clock);
-       if (!r)
+       if (!r) {
+               clk_disable_unprepare(clock);
                return -ENODEV;
+       }
 
        if (is_ick)
                t->ick = clock;