Remove redundant method

diff --git a/atom/common/platform_util_linux.cc b/atom/common/platform_util_linux.cc
index bf3c3b2..3aabe37 100644 (file)
--- a/atom/common/platform_util_linux.cc
+++ b/atom/common/platform_util_linux.cc
@@ -79,7 +79,7 @@ bool OpenItem(const base::FilePath& full_path) {
   return XDGOpen(full_path.value(), true);
 }
 
-bool openExternal(const GURL& url, bool activate) {
+bool OpenExternal(const GURL& url, bool activate) {
   // Don't wait for exit, since we don't want to wait for the browser/email
   // client window to close before returning
   if (url.SchemeIs("mailto"))
@@ -88,13 +88,9 @@ bool openExternal(const GURL& url, bool activate) {
     return XDGOpen(url.spec(), false);
 }
 
-bool OpenExternal(const GURL& url, bool activate) {
-  return openExternal(url, activate);
-}
-
 bool OpenExternal(const GURL& url, bool activate, const OpenExternalCallback& callback) {
   // TODO: Implement async open if callback is specified
-  bool opened = openExternal(url, activate);
+  bool opened = OpenExternal(url, activate);
   callback.Run(opened);
   return opened;
 }

diff --git a/atom/common/platform_util_win.cc b/atom/common/platform_util_win.cc
index dd0121b..f859193 100644 (file)
--- a/atom/common/platform_util_win.cc
+++ b/atom/common/platform_util_win.cc
@@ -299,7 +299,7 @@ bool OpenItem(const base::FilePath& full_path) {
     return ui::win::OpenFileViaShell(full_path);
 }
 
-bool openExternal(const base::string16& url, bool activate) {
+bool OpenExternal(const base::string16& url, bool activate) {
   // Quote the input scheme to be sure that the command does not have
   // parameters unexpected by the external program. This url should already
   // have been escaped.
@@ -316,13 +316,9 @@ bool openExternal(const base::string16& url, bool activate) {
   return true;
 }
 
-bool OpenExternal(const base::string16& url, bool activate) {
-  return openExternal(url, activate);
-}
-
 bool OpenExternal(const base::string16& url, bool activate, const OpenExternalCallback& callback) {
   // TODO: Implement async open if callback is specified
-  bool opened = openExternal(url, activate);
+  bool opened = OpenExternal(url, activate);
   callback.Run(opened);
   return opened;
 }