leds: trigger: oneshot: Add initialization from Device Tree
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 9 Jan 2019 14:44:48 +0000 (15:44 +0100)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Wed, 16 Jan 2019 21:09:18 +0000 (22:09 +0100)
Allow initialization of delays used in oneshot trigger from Device
Tree property.

This is especially useful for embedded systems where the trigger might
be used early, before bringing up user-space.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
drivers/leds/trigger/ledtrig-oneshot.c

index 95c9be4..8808f0a 100644 (file)
@@ -130,6 +130,34 @@ static struct attribute *oneshot_trig_attrs[] = {
 };
 ATTRIBUTE_GROUPS(oneshot_trig);
 
+static void pattern_init(struct led_classdev *led_cdev)
+{
+       u32 *pattern;
+       unsigned int size = 0;
+
+       pattern = led_get_default_pattern(led_cdev, &size);
+       if (!pattern)
+               goto out_default;
+
+       if (size != 2) {
+               dev_warn(led_cdev->dev,
+                        "Expected 2 but got %u values for delays pattern\n",
+                        size);
+               goto out_default;
+       }
+
+       led_cdev->blink_delay_on = pattern[0];
+       led_cdev->blink_delay_off = pattern[1];
+       kfree(pattern);
+
+       return;
+
+out_default:
+       kfree(pattern);
+       led_cdev->blink_delay_on = DEFAULT_DELAY;
+       led_cdev->blink_delay_off = DEFAULT_DELAY;
+}
+
 static int oneshot_trig_activate(struct led_classdev *led_cdev)
 {
        struct oneshot_trig_data *oneshot_data;
@@ -140,8 +168,14 @@ static int oneshot_trig_activate(struct led_classdev *led_cdev)
 
        led_set_trigger_data(led_cdev, oneshot_data);
 
-       led_cdev->blink_delay_on = DEFAULT_DELAY;
-       led_cdev->blink_delay_off = DEFAULT_DELAY;
+       if (led_cdev->flags & LED_INIT_DEFAULT_TRIGGER) {
+               pattern_init(led_cdev);
+               /*
+                * Mark as initialized even on pattern_init() error because
+                * any consecutive call to it would produce the same error.
+                */
+               led_cdev->flags &= ~LED_INIT_DEFAULT_TRIGGER;
+       }
 
        return 0;
 }