projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
cb39c35
)
wifi: mwifiex: fix memory leak in mwifiex_histogram_read()
author
Dmitry Antipov
<dmantipov@yandex.ru>
Wed, 2 Aug 2023 16:07:15 +0000
(19:07 +0300)
committer
Kalle Valo
<kvalo@kernel.org>
Mon, 21 Aug 2023 15:56:26 +0000
(18:56 +0300)
Always free the zeroed page on return from 'mwifiex_histogram_read()'.
Fixes:
cbf6e05527a7
("mwifiex: add rx histogram statistics support")
Acked-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link:
https://lore.kernel.org/r/20230802160726.85545-1-dmantipov@yandex.ru
drivers/net/wireless/marvell/mwifiex/debugfs.c
patch
|
blob
|
history
diff --git
a/drivers/net/wireless/marvell/mwifiex/debugfs.c
b/drivers/net/wireless/marvell/mwifiex/debugfs.c
index
52b18f4
..
0cdd6c5
100644
(file)
--- a/
drivers/net/wireless/marvell/mwifiex/debugfs.c
+++ b/
drivers/net/wireless/marvell/mwifiex/debugfs.c
@@
-253,8
+253,11
@@
mwifiex_histogram_read(struct file *file, char __user *ubuf,
if (!p)
return -ENOMEM;
- if (!priv || !priv->hist_data)
- return -EFAULT;
+ if (!priv || !priv->hist_data) {
+ ret = -EFAULT;
+ goto free_and_exit;
+ }
+
phist_data = priv->hist_data;
p += sprintf(p, "\n"
@@
-309,6
+312,8
@@
mwifiex_histogram_read(struct file *file, char __user *ubuf,
ret = simple_read_from_buffer(ubuf, count, ppos, (char *)page,
(unsigned long)p - page);
+free_and_exit:
+ free_page(page);
return ret;
}