Make egde effect effective
authorAntonio Gomes <a1.gomes@samsung.com>
Tue, 19 May 2015 15:29:28 +0000 (11:29 -0400)
committerYoungsoo Choi <kenshin.choi@samsung.com>
Tue, 10 Jul 2018 06:57:09 +0000 (06:57 +0000)
Now that Edge Effect is brought up (see [1]), patch
make it effective for scroll/pinch gestures.

What is does? It hides the overscroll indicator
when it is not needed.

[1] http://165.213.202.130/gerrit/#/c/76762/
:
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13002
Reviewed by: Piotr Tworek, arno renevier

Change-Id: I98a80374d6b8424b9af80a862c5795b21fc28a00
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
tizen_src/chromium_impl/content/browser/renderer_host/render_widget_host_view_efl.cc

index 33839c7..e4548de 100644 (file)
@@ -1400,7 +1400,10 @@ void RenderWidgetHostViewEfl::HandleGesture(
     was_scrolled_ = true;
     if (GetSelectionController())
       GetSelectionController()->SetScrollStatus(true);
-  } else if (web_view_ && event.type == blink::WebInputEvent::GestureScrollUpdate) {
+  } else
+#endif
+  DCHECK(edge_effect_.get());
+  if (event.type == blink::WebInputEvent::GestureScrollUpdate) {
     if (event.data.scrollUpdate.deltaX < 0)
       edge_effect_->Hide("edge,left");
     else if (event.data.scrollUpdate.deltaX > 0)
@@ -1409,12 +1412,11 @@ void RenderWidgetHostViewEfl::HandleGesture(
       edge_effect_->Hide("edge,top");
     else if (event.data.scrollUpdate.deltaY > 0)
       edge_effect_->Hide("edge,bottom");
-  } else if (web_view_ && event.type == blink::WebInputEvent::GesturePinchBegin) {
+  } else if (event.type == blink::WebInputEvent::GesturePinchBegin) {
     edge_effect_->Disable();
-  } else if (web_view_ && event.type == blink::WebInputEvent::GesturePinchEnd) {
+  } else if (event.type == blink::WebInputEvent::GesturePinchEnd) {
     edge_effect_->Enable();
   }
-#endif
 }
 
 void RenderWidgetHostViewEfl::HandleGesture(ui::GestureEvent* event) {