media: rc: i2c: Fix an error message
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 6 May 2021 05:38:56 +0000 (07:38 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sun, 23 May 2021 17:21:24 +0000 (19:21 +0200)
'ret' is known to be 1 here. In fact 'i' is expected instead.
Store the return value of 'i2c_master_recv()' in 'ret' so that the error
message print the correct error code.

Fixes: acaa34bf06e9 ("media: rc: implement zilog transmitter")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/ir-kbd-i2c.c

index e8119ad..9237659 100644 (file)
@@ -678,8 +678,8 @@ static int zilog_tx(struct rc_dev *rcdev, unsigned int *txbuf,
                goto out_unlock;
        }
 
-       i = i2c_master_recv(ir->tx_c, buf, 1);
-       if (i != 1) {
+       ret = i2c_master_recv(ir->tx_c, buf, 1);
+       if (ret != 1) {
                dev_err(&ir->rc->dev, "i2c_master_recv failed with %d\n", ret);
                ret = -EIO;
                goto out_unlock;