Fix double free 52/264352/2
authorChangyeon Lee <cyeon.lee@samsung.com>
Thu, 16 Sep 2021 07:57:48 +0000 (16:57 +0900)
committerChangyeon Lee <cyeon.lee@samsung.com>
Thu, 16 Sep 2021 08:47:00 +0000 (17:47 +0900)
request is freed in _meson_output_atomic_commit

Change-Id: I4693baa197d9e178afff2ff631fe7301d0235006

src/tdm_meson_display.c

index 5b247b25f5252d0f587c0030dc5bb3dc018f87e4..83b1fb6920c9d0b1f4cbcf6b74aae07121603d27 100644 (file)
@@ -1404,7 +1404,6 @@ _meson_output_make_atomic_request(tdm_meson_output *output_data, drmModeAtomicRe
                current_mode = _tdm_meson_display_get_mode(output_data);
                if (!current_mode) {
                        TDM_BACKEND_ERR("couldn't find proper mode");
-                       drmModeAtomicFree(request);
                        return HAL_TDM_ERROR_BAD_REQUEST;
                }
 
@@ -1466,7 +1465,6 @@ _meson_output_make_atomic_request(tdm_meson_output *output_data, drmModeAtomicRe
                                output_data->atomic_props_ids.out_fence_ptr, (uintptr_t)out_fence_fd);
        if (ret < 0) {
                TDM_BACKEND_ERR("fail to out fence ptr error:%d", errno);
-               drmModeAtomicFree(request);
                return ret;
        }