Use const references for params
authorKevin Sawicki <kevinsawicki@gmail.com>
Mon, 3 Apr 2017 17:57:57 +0000 (10:57 -0700)
committerKevin Sawicki <kevinsawicki@gmail.com>
Tue, 4 Apr 2017 20:51:39 +0000 (13:51 -0700)
atom/browser/ui/cocoa/atom_touch_bar.mm

index 674f572..9445014 100644 (file)
@@ -115,8 +115,8 @@ static NSString* const ImageScrubberItemIdentifier = @"scrubber.image.item";
 
 - (void)refreshTouchBarItem:(NSTouchBar*)touchBar
                          id:(NSTouchBarItemIdentifier)identifier
-                   withType:(std::string)item_type
-               withSettings:(mate::PersistentDictionary)settings {
+                   withType:(const std::string&)item_type
+               withSettings:(const mate::PersistentDictionary&)settings {
   NSTouchBarItem* item = [touchBar itemForIdentifier:identifier];
   if (!item) return;