pwm: clps711x: Simplify using devm_pwmchip_add()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sun, 23 May 2021 13:34:43 +0000 (15:34 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Mon, 28 Jun 2021 11:23:11 +0000 (13:23 +0200)
With devm_pwmchip_add() we can drop pwmchip_remove() from the device
remove callback. The latter can then go away, too and as this is the
only user of platform_get_drvdata(), the respective call to
platform_set_drvdata() can go, too.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-clps711x.c

index f3d17a5..d7ad886 100644 (file)
@@ -134,16 +134,7 @@ static int clps711x_pwm_probe(struct platform_device *pdev)
 
        spin_lock_init(&priv->lock);
 
-       platform_set_drvdata(pdev, priv);
-
-       return pwmchip_add(&priv->chip);
-}
-
-static int clps711x_pwm_remove(struct platform_device *pdev)
-{
-       struct clps711x_chip *priv = platform_get_drvdata(pdev);
-
-       return pwmchip_remove(&priv->chip);
+       return devm_pwmchip_add(&pdev->dev, &priv->chip);
 }
 
 static const struct of_device_id __maybe_unused clps711x_pwm_dt_ids[] = {
@@ -158,7 +149,6 @@ static struct platform_driver clps711x_pwm_driver = {
                .of_match_table = of_match_ptr(clps711x_pwm_dt_ids),
        },
        .probe = clps711x_pwm_probe,
-       .remove = clps711x_pwm_remove,
 };
 module_platform_driver(clps711x_pwm_driver);