Fix bugs - duplicated naviframe item, and i18n 33/139633/1 accepted/tizen/4.0/unified/20170816.015348 accepted/tizen/4.0/unified/20170828.223052 accepted/tizen/unified/20170728.195335 submit/tizen/20170727.055818 submit/tizen_4.0/20170811.094300 submit/tizen_4.0/20170814.115522 submit/tizen_4.0/20170828.100009 submit/tizen_4.0_unified/20170814.115522 tizen_4.0.IoT.p1_release
authorShinwoo Kim <cinoo.kim@samsung.com>
Wed, 19 Jul 2017 23:23:40 +0000 (08:23 +0900)
committerShinwoo Kim <cinoo.kim@samsung.com>
Wed, 19 Jul 2017 23:27:55 +0000 (08:27 +0900)
(1) duplicated naviframe item - app_control created what app_create created.
    So there were two pushed same(duplicated) naviframe items.
(2) i18n - The message ID was used without using gettext

Change-Id: Ib25f543d80337af1ef0fd9ab1d634f93206dd6b6

src/setting-accessibility-menu.c
src/setting-accessibility-vision.c
src/setting-accessibility.c

index 21956d1..819c7c1 100644 (file)
@@ -134,7 +134,7 @@ Evas_Object *setting_accessibility_menu_create_view(void *data)
        elm_object_part_content_set(pObj_layout, "elm.genlist", pObj_genlist);
 
        Elm_Object_Item *pObjItem_nf = NULL;
-       pObjItem_nf = elm_naviframe_item_push(ad->pObj_nf, "IDS_ST_BODY_ACCESSIBILITY", NULL, NULL, pObj_layout, "empty");
+       pObjItem_nf = elm_naviframe_item_push(ad->pObj_nf, access_gettext("IDS_ST_BODY_ACCESSIBILITY"), NULL, NULL, pObj_layout, "empty");
        elm_naviframe_item_title_enabled_set(pObjItem_nf, EINA_FALSE, EINA_FALSE);
        elm_object_item_domain_text_translatable_set(pObjItem_nf, SETTING_ACCESSIBILITY_PACKAGE_NAME, EINA_TRUE);
        elm_naviframe_item_pop_cb_set(pObjItem_nf, __setting_accessibility_menu_naviframe_pop_cb, NULL);        // pop callback
index 66e6a59..76ab7ae 100644 (file)
@@ -202,7 +202,7 @@ setting_accessibility_vision_create_view(void *data)
        elm_object_part_content_set(pObj_layout, "elm.genlist", pObj_genlist);
 
        Elm_Object_Item *pObjItem_nf = NULL;
-       pObjItem_nf = elm_naviframe_item_push(ad->pObj_nf, "IDS_ST_HEADER_VISION", NULL, NULL, pObj_layout, "empty");
+       pObjItem_nf = elm_naviframe_item_push(ad->pObj_nf, access_gettext("IDS_ST_HEADER_VISION"), NULL, NULL, pObj_layout, "empty");
        elm_naviframe_item_title_enabled_set(pObjItem_nf, EINA_FALSE, EINA_FALSE);
        elm_object_item_domain_text_translatable_set(pObjItem_nf, SETTING_ACCESSIBILITY_PACKAGE_NAME, EINA_TRUE);
        elm_naviframe_item_pop_cb_set(pObjItem_nf, __setting_accessibility_vision_naviframe_pop_cb, NULL);
index d087708..b8b4e78 100644 (file)
@@ -145,8 +145,6 @@ app_control(app_control_h app_control, void *data)
 
        DBG("API() entered.");
 
-       __setting_accessibility_create_common_view(ad);
-       setting_accessibility_menu_create_view(ad);
        elm_win_activate(ad->pObj_win_main);
 }
 
@@ -229,10 +227,10 @@ main(int argc, char *argv[])
        app_event_handler_h handlers[5] = {NULL, };
 
        event_callback.create = app_create;
+       event_callback.app_control = app_control;
+       event_callback.resume = app_resume;
        event_callback.terminate = app_terminate;
        event_callback.pause = app_pause;
-       event_callback.resume = app_resume;
-       event_callback.app_control = app_control;
 
        ui_app_add_event_handler(&handlers[APP_EVENT_LOW_BATTERY], APP_EVENT_LOW_BATTERY, ui_app_low_battery, &ad);
        ui_app_add_event_handler(&handlers[APP_EVENT_LOW_MEMORY], APP_EVENT_LOW_MEMORY, ui_app_low_memory, &ad);