mmc: meson-gx: ack only raised irq
authorJerome Brunet <jbrunet@baylibre.com>
Tue, 23 Apr 2019 09:02:30 +0000 (11:02 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 6 May 2019 09:55:39 +0000 (11:55 +0200)
This is merely a clean up. It makes sense to only ack raised irqs
instead of acking everything all the time.

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/meson-gx-mmc.c

index 2deeacc..8b690ec 100644 (file)
@@ -1082,9 +1082,6 @@ static irqreturn_t meson_mmc_irq(int irq, void *dev_id)
        }
 
 out:
-       /* ack all enabled interrupts */
-       writel(irq_en, host->regs + SD_EMMC_STATUS);
-
        if (cmd->error) {
                /* Stop desc in case of errors */
                u32 start = readl(host->regs + SD_EMMC_START);
@@ -1096,6 +1093,9 @@ out:
        if (ret == IRQ_HANDLED)
                meson_mmc_request_done(host->mmc, cmd->mrq);
 
+       /* ack all raised interrupts */
+       writel(status, host->regs + SD_EMMC_STATUS);
+
        return ret;
 }