net: dpaa: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230710071946.3470249-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index e0e5bf0..85e38a1 100644 (file)
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -3497,7 +3497,7 @@ free_netdev:
        return err;
 }
 
-static int dpaa_remove(struct platform_device *pdev)
+static void dpaa_remove(struct platform_device *pdev)
 {
        struct net_device *net_dev;
        struct dpaa_priv *priv;
@@ -3530,8 +3530,6 @@ static int dpaa_remove(struct platform_device *pdev)
        dpaa_bps_free(priv);
 
        free_netdev(net_dev);
-
-       return 0;
 }
 
 static const struct platform_device_id dpaa_devtype[] = {
@@ -3549,7 +3547,7 @@ static struct platform_driver dpaa_driver = {
        },
        .id_table = dpaa_devtype,
        .probe = dpaa_eth_probe,
-       .remove = dpaa_remove
+       .remove_new = dpaa_remove
 };
 
 static int __init dpaa_load(void)