habanalabs: Add check for pci_enable_device
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Thu, 24 Feb 2022 06:58:05 +0000 (14:58 +0800)
committerOded Gabbay <ogabbay@kernel.org>
Mon, 28 Feb 2022 12:22:06 +0000 (14:22 +0200)
As the potential failure of the pci_enable_device(),
it should be better to check the return value and return
error if fails.

Fixes: 70b2f993ea4a ("habanalabs: create common folder")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/misc/habanalabs/common/debugfs.c

index 9f0aaf0..f184955 100644 (file)
@@ -890,6 +890,8 @@ static ssize_t hl_set_power_state(struct file *f, const char __user *buf,
                pci_set_power_state(hdev->pdev, PCI_D0);
                pci_restore_state(hdev->pdev);
                rc = pci_enable_device(hdev->pdev);
+               if (rc < 0)
+                       return rc;
        } else if (value == 2) {
                pci_save_state(hdev->pdev);
                pci_disable_device(hdev->pdev);