glupload: prevent segfault when updating caps
authorMichael Tretter <m.tretter@pengutronix.de>
Wed, 23 Jan 2019 11:50:40 +0000 (12:50 +0100)
committerMichael Tretter <m.tretter@pengutronix.de>
Fri, 12 Apr 2019 10:05:22 +0000 (12:05 +0200)
When the glupload element renegotiates the caps, set_caps will reset the
method_impl to NULL, but the method will be kept. transform_caps tries
to use the method_impl to transform the caps, because a method is set,
but will segfault.

gst-libs/gst/gl/gstglupload.c

index c10c023..bf6b62d 100644 (file)
@@ -1869,6 +1869,7 @@ _gst_gl_upload_set_caps_unlocked (GstGLUpload * upload, GstCaps * in_caps,
   gst_video_info_from_caps (&upload->priv->in_info, in_caps);
   gst_video_info_from_caps (&upload->priv->out_info, out_caps);
 
+  upload->priv->method = NULL;
   upload->priv->method_impl = NULL;
   upload->priv->method_i = 0;