phy: phy-rockchip-inno-usb2: support #address_cells = 2
authorPeter Geis <pgwipeout@gmail.com>
Wed, 15 Dec 2021 21:02:47 +0000 (16:02 -0500)
committerVinod Koul <vkoul@kernel.org>
Thu, 23 Dec 2021 11:24:48 +0000 (16:54 +0530)
New Rockchip devices have the usb phy nodes as standalone devices.
These nodes have register nodes with #address_cells = 2, but only use 32
bit addresses.

Adjust the driver to check if the returned address is "0", and adjust
the index in that case.

Signed-off-by: Peter Geis <pgwipeout@gmail.com>
Tested-by: Michael Riesch <michael.riesch@wolfvision.net>
Link: https://lore.kernel.org/r/20211215210252.120923-4-pgwipeout@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/phy-rockchip-inno-usb2.c

index 9f95b58..fac390e 100644 (file)
@@ -1090,12 +1090,21 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
                rphy->usbgrf = NULL;
        }
 
-       if (of_property_read_u32(np, "reg", &reg)) {
+       if (of_property_read_u32_index(np, "reg", 0, &reg)) {
                dev_err(dev, "the reg property is not assigned in %pOFn node\n",
                        np);
                return -EINVAL;
        }
 
+       /* support address_cells=2 */
+       if (reg == 0) {
+               if (of_property_read_u32_index(np, "reg", 1, &reg)) {
+                       dev_err(dev, "the reg property is not assigned in %pOFn node\n",
+                               np);
+                       return -EINVAL;
+               }
+       }
+
        rphy->dev = dev;
        phy_cfgs = match->data;
        rphy->chg_state = USB_CHG_STATE_UNDEFINED;