USB: core: no need to save usb_devices_root
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 16 Feb 2021 10:14:32 +0000 (11:14 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Mar 2021 08:37:15 +0000 (09:37 +0100)
There is no need to save the usb_devices debugfs file as we only need it
when removing it, so have the debugfs code look it up when it is needed
instead, saving the storage.

Link: https://lore.kernel.org/r/YCubCA/trHAF7PtF@kroah.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/usb.c

index 8f07b05..829dc8e 100644 (file)
@@ -950,17 +950,15 @@ static struct notifier_block usb_bus_nb = {
        .notifier_call = usb_bus_notify,
 };
 
-static struct dentry *usb_devices_root;
-
 static void usb_debugfs_init(void)
 {
-       usb_devices_root = debugfs_create_file("devices", 0444, usb_debug_root,
-                                              NULL, &usbfs_devices_fops);
+       debugfs_create_file("devices", 0444, usb_debug_root, NULL,
+                           &usbfs_devices_fops);
 }
 
 static void usb_debugfs_cleanup(void)
 {
-       debugfs_remove(usb_devices_root);
+       debugfs_remove(debugfs_lookup("devices", usb_debug_root));
 }
 
 /*