dmaengine: fsl-edma: remove redundant assignment to pointer last_sg
authorColin Ian King <colin.i.king@gmail.com>
Tue, 14 Jun 2022 18:47:59 +0000 (19:47 +0100)
committerVinod Koul <vkoul@kernel.org>
Fri, 1 Jul 2022 16:39:16 +0000 (22:09 +0530)
The pointer last_sg is being assigned a value at the start of a loop
however it is never read and is being re-assigned later on in both
brances of an if-statement. The assignment is redundant and can be
removed.

Cleans up clang scan-build warning:
drivers/dma/fsl-edma-common.c:563:3: warning: Value stored to 'last_sg'
is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20220614184759.164379-1-colin.i.king@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/fsl-edma-common.c

index 3ae05d1..a06a157 100644 (file)
@@ -559,9 +559,6 @@ struct dma_async_tx_descriptor *fsl_edma_prep_slave_sg(
        }
 
        for_each_sg(sgl, sg, sg_len, i) {
-               /* get next sg's physical address */
-               last_sg = fsl_desc->tcd[(i + 1) % sg_len].ptcd;
-
                if (direction == DMA_MEM_TO_DEV) {
                        src_addr = sg_dma_address(sg);
                        dst_addr = fsl_chan->dma_dev_addr;