fs/squashfs: sqfs_probe: use sqfs_decompressor_init() return value 85/250885/1
authorRichard Genoud <richard.genoud@posteo.net>
Tue, 3 Nov 2020 11:11:22 +0000 (12:11 +0100)
committerJaehoon Chung <jh80.chung@samsung.com>
Tue, 5 Jan 2021 07:11:25 +0000 (16:11 +0900)
sqfs_decompressor_init() returns a value, so it's better to use it than
to force the return value to EINVAL (it could be ENOMEM)

Reviewed-by: Joao Marcos Costa <jmcosta944@gmail.com>
Signed-off-by: Richard Genoud <richard.genoud@posteo.net>
[jh80.chung: cherry picked from mainline commit 6d25bd3e9c1d317cdbd52a4c6bba11f912bb4d6a]
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Change-Id: I7fcad9cd4d7ecb4aff6aa353aee78c7aac69a0e6

fs/squashfs/sqfs.c

index 6fcc5de..c8aded4 100644 (file)
@@ -1100,9 +1100,7 @@ int sqfs_probe(struct blk_desc *fs_dev_desc, struct disk_partition *fs_partition
        ctxt.sblk = sblk;
 
        ret = sqfs_decompressor_init(&ctxt);
-
        if (ret) {
-               ret = -EINVAL;
                goto error;
        }