net: dsa: microchip: clean up code
authorTristram Ha <Tristram.Ha@microchip.com>
Tue, 20 Nov 2018 23:55:06 +0000 (15:55 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Nov 2018 04:57:12 +0000 (20:57 -0800)
Clean up code according to patch check suggestions.

Signed-off-by: Tristram Ha <Tristram.Ha@microchip.com>
Reviewed-by: Woojung Huh <Woojung.Huh@microchip.com>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/microchip/ksz_common.c

index d47d03b..eb833df 100644 (file)
@@ -890,9 +890,9 @@ static void ksz_port_mdb_add(struct dsa_switch *ds, int port,
 
                if (static_table[0] & ALU_V_STATIC_VALID) {
                        /* check this has same vid & mac address */
-                       if (((static_table[2] >> ALU_V_FID_S) == (mdb->vid)) &&
+                       if (((static_table[2] >> ALU_V_FID_S) == mdb->vid) &&
                            ((static_table[2] & ALU_V_MAC_ADDR_HI) == mac_hi) &&
-                           (static_table[3] == mac_lo)) {
+                           static_table[3] == mac_lo) {
                                /* found matching one */
                                break;
                        }
@@ -963,9 +963,9 @@ static int ksz_port_mdb_del(struct dsa_switch *ds, int port,
                if (static_table[0] & ALU_V_STATIC_VALID) {
                        /* check this has same vid & mac address */
 
-                       if (((static_table[2] >> ALU_V_FID_S) == (mdb->vid)) &&
+                       if (((static_table[2] >> ALU_V_FID_S) == mdb->vid) &&
                            ((static_table[2] & ALU_V_MAC_ADDR_HI) == mac_hi) &&
-                           (static_table[3] == mac_lo)) {
+                           static_table[3] == mac_lo) {
                                /* found matching one */
                                break;
                        }