ext: Fix various compiler warnings with clang

wldisplay.c:179:15: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-compare]
  if (shm_fmt < 0)
      ~~~~~~~ ^ ~

gstsegmentation.cpp:419:40: error: implicit conversion from 'int' to 'char' changes value from 255 to -1 [-Werror,-Wconstant-conversion]
          filter->cvFG->imageData[j] = 255;
                                     ~ ^~~

https://bugzilla.gnome.org/show_bug.cgi?id=775112

diff --git a/ext/opencv/gstsegmentation.cpp b/ext/opencv/gstsegmentation.cpp
index 472a3c4..d67bb9a 100644 (file)
--- a/ext/opencv/gstsegmentation.cpp
+++ b/ext/opencv/gstsegmentation.cpp
@@ -416,7 +416,7 @@ gst_segmentation_transform_ip (GstVideoFilter * btrans, GstVideoFrame * frame)
         if (background_diff
             ((uchar *) filter->cvYUV->imageData + j * 3,
                 (codeBook *) & (filter->TcodeBook[j]), 3, minMod, maxMod)) {
-          filter->cvFG->imageData[j] = 255;
+          filter->cvFG->imageData[j] = (char) 255;
         } else {
           filter->cvFG->imageData[j] = 0;
         }

diff --git a/ext/wayland/wldisplay.c b/ext/wayland/wldisplay.c
index 07a203c..39782bc 100644 (file)
--- a/ext/wayland/wldisplay.c
+++ b/ext/wayland/wldisplay.c
@@ -176,7 +176,7 @@ gst_wl_display_check_format_for_shm (GstWlDisplay * display,
   guint i;
 
   shm_fmt = gst_video_format_to_wl_shm_format (format);
-  if (shm_fmt < 0)
+  if (shm_fmt == (enum wl_shm_format) -1)
     return FALSE;
 
   formats = display->shm_formats;