logger: Fix incorrect buffer access when writing data 55/256655/2 accepted/tizen/unified/20210412.012045 submit/tizen/20210409.113436
authorŁukasz Stelmach <l.stelmach@samsung.com>
Thu, 8 Apr 2021 12:09:24 +0000 (14:09 +0200)
committerŁukasz Stelmach <l.stelmach@samsung.com>
Fri, 9 Apr 2021 09:09:49 +0000 (11:09 +0200)
Fix crash caused by accessing memory beyond log->buffer

Change-Id: I528b62e34e9fb5f92f62f6b218718e15cd5f7d31
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
drivers/staging/android/logger.c

index c860dae..df9f246 100644 (file)
@@ -531,7 +531,7 @@ static void write_log_data(struct logger_log *log,
 
        /* message */
        len = min(chunk_len, log->size - w_off);
-       memcpy(log->buffer + w_off, writer->buffer, chunk_len);
+       memcpy(log->buffer + w_off, writer->buffer, len);
        memcpy(log->buffer, writer->buffer + len, chunk_len - len);
        log->w_off = logger_offset(log, w_off + chunk_len);
 }