netfilter: ctnetlink: Support offloaded conntrack entry deletion
authorPaul Blakey <paulb@nvidia.com>
Wed, 22 Mar 2023 07:35:32 +0000 (09:35 +0200)
committerFlorian Westphal <fw@strlen.de>
Thu, 30 Mar 2023 20:20:09 +0000 (22:20 +0200)
Currently, offloaded conntrack entries (flows) can only be deleted
after they are removed from offload, which is either by timeout,
tcp state change or tc ct rule deletion. This can cause issues for
users wishing to manually delete or flush existing entries.

Support deletion of offloaded conntrack entries.

Example usage:
 # Delete all offloaded (and non offloaded) conntrack entries
 # whose source address is 1.2.3.4
 $ conntrack -D -s 1.2.3.4
 # Delete all entries
 $ conntrack -F

Signed-off-by: Paul Blakey <paulb@nvidia.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Florian Westphal <fw@strlen.de>
net/netfilter/nf_conntrack_netlink.c

index bfc3aaa..fbc47e4 100644 (file)
@@ -1554,9 +1554,6 @@ static const struct nla_policy ct_nla_policy[CTA_MAX+1] = {
 
 static int ctnetlink_flush_iterate(struct nf_conn *ct, void *data)
 {
-       if (test_bit(IPS_OFFLOAD_BIT, &ct->status))
-               return 0;
-
        return ctnetlink_filter_match(ct, data);
 }
 
@@ -1626,11 +1623,6 @@ static int ctnetlink_del_conntrack(struct sk_buff *skb,
 
        ct = nf_ct_tuplehash_to_ctrack(h);
 
-       if (test_bit(IPS_OFFLOAD_BIT, &ct->status)) {
-               nf_ct_put(ct);
-               return -EBUSY;
-       }
-
        if (cda[CTA_ID]) {
                __be32 id = nla_get_be32(cda[CTA_ID]);