ext/theora/theoradec.c: gst_pad_push_event() does not return a GstFlowReturn!
authorMichael Smith <msmith@xiph.org>
Wed, 9 May 2007 11:54:32 +0000 (11:54 +0000)
committerMichael Smith <msmith@xiph.org>
Wed, 9 May 2007 11:54:32 +0000 (11:54 +0000)
Original commit message from CVS:
* ext/theora/theoradec.c: (theora_handle_type_packet):
gst_pad_push_event() does not return a GstFlowReturn!

ChangeLog
ext/theora/theoradec.c

index f29e25f..95a3937 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2007-05-09  Michael Smith <msmith@fluendo.com>
+
+       * ext/theora/theoradec.c: (theora_handle_type_packet):
+         gst_pad_push_event() does not return a GstFlowReturn!
+
 2007-05-09  Wim Taymans  <wim@fluendo.com>
 
        * tests/examples/seek/scrubby.c: (stop_cb), (main):
index 984a778..89bb6f2 100644 (file)
@@ -771,6 +771,7 @@ theora_handle_type_packet (GstTheoraDec * dec, ogg_packet * packet)
   GstCaps *caps;
   gint par_num, par_den;
   GstFlowReturn ret = GST_FLOW_OK;
+  gboolean eret;
   GstEvent *event;
 
   GST_DEBUG_OBJECT (dec, "fps %d/%d, PAR %d/%d",
@@ -845,7 +846,9 @@ theora_handle_type_packet (GstTheoraDec * dec, ogg_packet * packet)
         dec->segment.rate, dec->segment.applied_rate,
         dec->segment.format, dec->segment.start, dec->segment.stop,
         dec->segment.time);
-    ret = gst_pad_push_event (dec->srcpad, event);
+    eret = gst_pad_push_event (dec->srcpad, event);
+    if (!eret)
+      ret = GST_FLOW_ERROR;
     dec->sent_newsegment = TRUE;
   }