Fix svace issues (183569, 183570, ...)

Change-Id: I3ad973688aca2fb1620d63b08d4d0bd457eb1f00
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>

diff --git a/bt-api/bt-event-handler.c b/bt-api/bt-event-handler.c
index 6395adb..9a3dcc1 100644 (file)
--- a/bt-api/bt-event-handler.c
+++ b/bt-api/bt-event-handler.c
@@ -2908,6 +2908,7 @@ static void __bt_tds_event_filter(GDBusConnection *connection,
                }
                buffer = (char *) g_variant_get_data(byte_var);
                memcpy(act_req.tds_data.data, buffer, act_req.tds_data.length);
+               g_free(buffer);
 
                _bt_convert_addr_string_to_type(act_req.rem_addr.addr, address);
 
@@ -2987,6 +2988,7 @@ static void __bt_tds_event_filter(GDBusConnection *connection,
 
                buffer = (char *) g_variant_get_data(byte_var);
                memcpy(ind_res.tds_data.data, buffer, ind_res.tds_data.length);
+               g_free(buffer);
 
                _bt_convert_addr_string_to_type(ind_res.rem_addr.addr, address);
 

diff --git a/bt-api/bt-gatt-service.c b/bt-api/bt-gatt-service.c
index 81a6ecc..969fc83 100644 (file)
--- a/bt-api/bt-gatt-service.c
+++ b/bt-api/bt-gatt-service.c
@@ -2060,6 +2060,7 @@ BT_EXPORT_API int bluetooth_gatt_add_descriptor(
        g_strfreev(line_argv);
        g_variant_builder_unref(inner_builder);
        g_variant_builder_unref(builder);
+       g_variant_builder_unref(builder2);
 
        return BLUETOOTH_ERROR_NONE;
 }
@@ -2274,7 +2275,9 @@ BT_EXPORT_API int bluetooth_gatt_update_characteristic(
                return BLUETOOTH_ERROR_INTERNAL;
        }
 
+/* Fix the svace issue : 185689
        outer_builder = g_variant_builder_new(G_VARIANT_TYPE("a{sv}"));
+*/
        invalidated_builder = g_variant_builder_new(G_VARIANT_TYPE("as"));
 
        inner_builder = g_variant_builder_new(G_VARIANT_TYPE_ARRAY);
@@ -2283,6 +2286,7 @@ BT_EXPORT_API int bluetooth_gatt_update_characteristic(
 
        update_value = g_variant_new("ay", inner_builder);
 
+
        outer_builder = g_variant_builder_new(G_VARIANT_TYPE_ARRAY);
        g_variant_builder_add(outer_builder, "{sv}", "Value",
                                        update_value);

diff --git a/bt-service/bt-service-event-receiver.c b/bt-service/bt-service-event-receiver.c
index 6a8231c..51da38c 100644 (file)
--- a/bt-service/bt-service-event-receiver.c
+++ b/bt-service/bt-service-event-receiver.c
@@ -2300,6 +2300,7 @@ void _bt_handle_device_event(GVariant *msg, const char *member, const char *path
                        ipsp_proxy = _bt_get_ipsp_proxy();
                        if (ipsp_proxy == NULL) {
                                BT_ERR("can not get ipsp proxy");
+                               g_free(address);
                                return;
                        }
 
@@ -2311,6 +2312,7 @@ void _bt_handle_device_event(GVariant *msg, const char *member, const char *path
                        ipsp_proxy = _bt_get_ipsp_proxy();
                        if (ipsp_proxy == NULL) {
                                BT_ERR("can not get ipsp proxy");
+                               g_free(address);
                                return;
                        }
 

diff --git a/bt-service/bt-service-tds.c b/bt-service/bt-service-tds.c
index 0bc83aa..13e216c 100644 (file)
--- a/bt-service/bt-service-tds.c
+++ b/bt-service/bt-service-tds.c
@@ -1157,12 +1157,16 @@ void _bt_tds_handle_activation_request(const char *path,
        if (0 == count)
                goto err;
 
+       g_free(address);
+
        BT_DBG("-");
        return;
 err:
        /* send activation response as error to bluez */
        __bt_tds_send_activation_response(address,
                TDS_CONTROL_POINT_RESPONSE_UNSUPPORTED_ORG_ID, NULL, 0);
+
+       g_free(address);
 }
 
 void _bt_tds_stop_by_terminated_process(char *name)