checkpatch: add warning for non-lore mailing list URLs
authorBjorn Helgaas <bhelgaas@google.com>
Wed, 19 Oct 2022 20:28:43 +0000 (15:28 -0500)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 18 Nov 2022 21:55:07 +0000 (13:55 -0800)
The lkml.org, marc.info, spinics.net, etc archives are not quite as useful
as lore.kernel.org because they use different styles, add advertising, and
may disappear in the future.  The lore archives are more consistent and
more likely to stick around, so prefer https://lore.kernel.org URLs when
they exist.

[bhelgaas@google.com: only warn if we see "http" before the archive hostname]
Link: https://lkml.kernel.org/r/20221114224315.GA939630@bhelgaas
Link: https://lkml.kernel.org/r/20221019202843.40810-1-helgaas@kernel.org
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Peter Collingbourne <pcc@google.com>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org> # build-tested
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
scripts/checkpatch.pl

index 1e5e66a..bd1b9d7 100755 (executable)
@@ -702,6 +702,17 @@ sub find_standard_signature {
        return "";
 }
 
+our $obsolete_archives = qr{(?xi:
+       \Qfreedesktop.org/archives/dri-devel\E |
+       \Qlists.infradead.org\E |
+       \Qlkml.org\E |
+       \Qmail-archive.com\E |
+       \Qmailman.alsa-project.org/pipermail\E |
+       \Qmarc.info\E |
+       \Qozlabs.org/pipermail\E |
+       \Qspinics.net\E
+)};
+
 our @typeListMisordered = (
        qr{char\s+(?:un)?signed},
        qr{int\s+(?:(?:un)?signed\s+)?short\s},
@@ -3324,6 +3335,12 @@ sub process {
                        $last_git_commit_id_linenr = $linenr if ($line =~ /\bcommit\s*$/i);
                }
 
+# Check for mailing list archives other than lore.kernel.org
+               if ($rawline =~ m{http.*\b$obsolete_archives}) {
+                       WARN("PREFER_LORE_ARCHIVE",
+                            "Use lore.kernel.org archive links when possible - see https://lore.kernel.org/lists.html\n" . $herecurr);
+               }
+
 # Check for added, moved or deleted files
                if (!$reported_maintainer_file && !$in_commit_log &&
                    ($line =~ /^(?:new|deleted) file mode\s*\d+\s*$/ ||