scsi: ses: Fix slab-out-of-bounds in ses_enclosure_data_process()

A fix for:

BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x949/0xe30 [ses]
Read of size 1 at addr ffff88a1b043a451 by task systemd-udevd/3271

Checking after (and before in next loop) addl_desc_ptr[1] is sufficient, we
expect the size to be sanitized before first access to addl_desc_ptr[1].
Make sure we don't walk beyond end of page.

Link: https://lore.kernel.org/r/20230202162451.15346-2-thenzl@redhat.com
Cc: stable@vger.kernel.org
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c
index 869ca9c7f23f731377e38beb21e930fe2cac92ea..034d605c307652e2500dff8c8e509f0d8d247e37 100644 (file)
--- a/drivers/scsi/ses.c
+++ b/drivers/scsi/ses.c
@@ -609,9 +609,11 @@ static void ses_enclosure_data_process(struct enclosure_device *edev,
                             /* these elements are optional */
                             type_ptr[0] == ENCLOSURE_COMPONENT_SCSI_TARGET_PORT ||
                             type_ptr[0] == ENCLOSURE_COMPONENT_SCSI_INITIATOR_PORT ||
-                            type_ptr[0] == ENCLOSURE_COMPONENT_CONTROLLER_ELECTRONICS))
+                            type_ptr[0] == ENCLOSURE_COMPONENT_CONTROLLER_ELECTRONICS)) {
                                addl_desc_ptr += addl_desc_ptr[1] + 2;
-
+                               if (addl_desc_ptr + 1 >= ses_dev->page10 + ses_dev->page10_len)
+                                       addl_desc_ptr = NULL;
+                       }
                }
        }
        kfree(buf);