usb: mtu3: cleanup with list_first_entry_or_null()
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Sat, 20 May 2017 17:05:31 +0000 (02:05 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 May 2017 12:30:13 +0000 (14:30 +0200)
The combo of list_empty() and list_first_entry() can be replaced with
list_first_entry_or_null().

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/mtu3/mtu3.h

index aa6fd6a..7b6dc23 100644 (file)
@@ -356,12 +356,8 @@ static inline struct mtu3_ep *to_mtu3_ep(struct usb_ep *ep)
 
 static inline struct mtu3_request *next_request(struct mtu3_ep *mep)
 {
-       struct list_head *queue = &mep->req_list;
-
-       if (list_empty(queue))
-               return NULL;
-
-       return list_first_entry(queue, struct mtu3_request, list);
+       return list_first_entry_or_null(&mep->req_list, struct mtu3_request,
+                                       list);
 }
 
 static inline void mtu3_writel(void __iomem *base, u32 offset, u32 data)