staging: bcm2835-audio: Drop useless NULL check
authorTakashi Iwai <tiwai@suse.de>
Tue, 4 Sep 2018 15:58:42 +0000 (17:58 +0200)
committerpopcornmix <popcornmix@gmail.com>
Mon, 13 May 2019 23:08:30 +0000 (00:08 +0100)
commit 8bcf9f252c29c2d5bcce3db605c0ebf1ef230f9c upstream.

alsa_stream->chip can be never NULL.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c

index c935c6e..13c61af 100644 (file)
@@ -188,8 +188,7 @@ static int snd_bcm2835_playback_close(struct snd_pcm_substream *substream)
        alsa_stream->buffer_size = 0;
 
        bcm2835_audio_close(alsa_stream);
-       if (alsa_stream->chip)
-               alsa_stream->chip->alsa_stream[alsa_stream->idx] = NULL;
+       alsa_stream->chip->alsa_stream[alsa_stream->idx] = NULL;
        /*
         * Do not free up alsa_stream here, it will be freed up by
         * runtime->private_free callback we registered in *_open above