remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing

Failing to read the "firmware-name" DT property without informing the
developer is annoying, add some helpful debug prints.

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20210312002605.3273255-1-bjorn.andersson@linaro.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
index 66106ba..15abfbb 100644 (file)
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -1661,8 +1661,10 @@ static int q6v5_probe(struct platform_device *pdev)
        mba_image = desc->hexagon_mba_image;
        ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name",
                                            0, &mba_image);
-       if (ret < 0 && ret != -EINVAL)
+       if (ret < 0 && ret != -EINVAL) {
+               dev_err(&pdev->dev, "unable to read mba firmware-name\n");
                return ret;
+       }
 
        rproc = rproc_alloc(&pdev->dev, pdev->name, &q6v5_ops,
                            mba_image, sizeof(*qproc));
@@ -1680,8 +1682,10 @@ static int q6v5_probe(struct platform_device *pdev)
        qproc->hexagon_mdt_image = "modem.mdt";
        ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name",
                                            1, &qproc->hexagon_mdt_image);
-       if (ret < 0 && ret != -EINVAL)
+       if (ret < 0 && ret != -EINVAL) {
+               dev_err(&pdev->dev, "unable to read mpss firmware-name\n");
                goto free_rproc;
+       }
 
        platform_set_drvdata(pdev, qproc);