thermal: cpu_cooling: Replace dev_warn with dev_err
authorViresh Kumar <viresh.kumar@linaro.org>
Tue, 7 Feb 2017 04:10:04 +0000 (09:40 +0530)
committerZhang Rui <rui.zhang@intel.com>
Mon, 13 Mar 2017 02:06:47 +0000 (10:06 +0800)
There isn't much the user can do on seeing these warnings, as the
hardware is actually okay. dev_err suits much better here.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
drivers/thermal/cpu_cooling.c

index 11b5ea6..59f0bd5 100644 (file)
@@ -397,9 +397,9 @@ static int get_static_power(struct cpufreq_cooling_device *cpufreq_device,
        dev_pm_opp_put(opp);
 
        if (voltage == 0) {
-               dev_warn_ratelimited(cpufreq_device->cpu_dev,
-                                    "Failed to get voltage for frequency %lu: %ld\n",
-                                    freq_hz, IS_ERR(opp) ? PTR_ERR(opp) : 0);
+               dev_err_ratelimited(cpufreq_device->cpu_dev,
+                                   "Failed to get voltage for frequency %lu: %ld\n",
+                                   freq_hz, IS_ERR(opp) ? PTR_ERR(opp) : 0);
                return -EINVAL;
        }
 
@@ -691,9 +691,9 @@ static int cpufreq_power2state(struct thermal_cooling_device *cdev,
 
        *state = cpufreq_cooling_get_level(cpu, target_freq);
        if (*state == THERMAL_CSTATE_INVALID) {
-               dev_warn_ratelimited(&cdev->device,
-                                    "Failed to convert %dKHz for cpu %d into a cdev state\n",
-                                    target_freq, cpu);
+               dev_err_ratelimited(&cdev->device,
+                                   "Failed to convert %dKHz for cpu %d into a cdev state\n",
+                                   target_freq, cpu);
                return -EINVAL;
        }