projects
/
platform
/
upstream
/
gstreamer.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
481e1f7
)
srtpenc: fix failure return values from create_session()
author
Tim-Philipp Müller
<tim@centricular.com>
Wed, 13 May 2015 11:31:44 +0000
(12:31 +0100)
committer
Tim-Philipp Müller
<tim@centricular.com>
Wed, 13 May 2015 11:32:53 +0000
(12:32 +0100)
create_session() returns an err_status_t with
err_status_ok=0 and err_status_fail=1, so
returning TRUE/FALSE is not quite right.
https://bugzilla.gnome.org/show_bug.cgi?id=749304
ext/srtp/gstsrtpenc.c
patch
|
blob
|
history
diff --git
a/ext/srtp/gstsrtpenc.c
b/ext/srtp/gstsrtpenc.c
index
f5e3f13
..
8489da4
100644
(file)
--- a/
ext/srtp/gstsrtpenc.c
+++ b/
ext/srtp/gstsrtpenc.c
@@
-428,7
+428,7
@@
gst_srtp_enc_create_session (GstSrtpEnc * filter)
GST_ELEMENT_ERROR (filter, LIBRARY, SETTINGS,
("Cipher is not NULL, key must be set"),
("Cipher is not NULL, key must be set"));
- return
FALSE
;
+ return
err_status_fail
;
}
expected = max_cipher_key_size (filter);
@@
-439,7
+439,7
@@
gst_srtp_enc_create_session (GstSrtpEnc * filter)
("Master key size is wrong"),
("Expected master key of %d bytes, but received %" G_GSIZE_FORMAT
" bytes", expected, keysize));
- return
FALSE
;
+ return
err_status_fail
;
}
}