ARM: davinci: dm644x evm: move pointer dereference below NULL check

Pointer dereference should be moved below the NULL test.

spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>

diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c
index f22572cee49d89ade236851a04fdf2ba94fed2e6..f8a99ee6bffc33760d22f0c8bb693aeea9ac6948 100644 (file)
--- a/arch/arm/mach-davinci/board-dm644x-evm.c
+++ b/arch/arm/mach-davinci/board-dm644x-evm.c
@@ -519,13 +519,11 @@ static int dm6444evm_msp430_get_pins(void)
        char buf[4];
        struct i2c_msg msg[2] = {
                {
-                       .addr = dm6446evm_msp->addr,
                        .flags = 0,
                        .len = 2,
                        .buf = (void __force *)txbuf,
                },
                {
-                       .addr = dm6446evm_msp->addr,
                        .flags = I2C_M_RD,
                        .len = 4,
                        .buf = buf,
@@ -536,6 +534,9 @@ static int dm6444evm_msp430_get_pins(void)
        if (!dm6446evm_msp)
                return -ENXIO;
 
+       msg[0].addr = dm6446evm_msp->addr;
+       msg[1].addr = dm6446evm_msp->addr;
+
        /* Command 4 == get input state, returns port 2 and port3 data
         *   S Addr W [A] len=2 [A] cmd=4 [A]
         *   RS Addr R [A] [len=4] A [cmd=4] A [port2] A [port3] N P