power: supply: sysfs: ratelimit property read error message
authorDavid Lechner <david@lechnology.com>
Thu, 13 Sep 2018 00:48:30 +0000 (19:48 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Oct 2019 10:30:09 +0000 (12:30 +0200)
[ Upstream commit 87a2b65fc855e6be50f791c2ebbb492541896827 ]

This adds rate limiting to the message that is printed when reading a
power supply property via sysfs returns an error. This will prevent
userspace applications from unintentionally dDOSing the system by
continuously reading a property that returns an error.

Signed-off-by: David Lechner <david@lechnology.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/power/supply/power_supply_sysfs.c

index c0fc98e03c912ca691ee8ff254b5d3d1e2fa80a4..85cb5b9c1b6f002e83d7fa736fb32232a7912804 100644 (file)
@@ -84,7 +84,8 @@ static ssize_t power_supply_show_property(struct device *dev,
                                dev_dbg(dev, "driver has no data for `%s' property\n",
                                        attr->attr.name);
                        else if (ret != -ENODEV && ret != -EAGAIN)
-                               dev_err(dev, "driver failed to report `%s' property: %zd\n",
+                               dev_err_ratelimited(dev,
+                                       "driver failed to report `%s' property: %zd\n",
                                        attr->attr.name, ret);
                        return ret;
                }