drm/amdgpu: fix the hibernation suspend with s0ix
authorPrike Liang <Prike.Liang@amd.com>
Tue, 9 Mar 2021 01:34:00 +0000 (09:34 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 22 Mar 2021 19:18:58 +0000 (15:18 -0400)
During system hibernation suspend still need un-gate gfx CG/PG firstly to handle HW
status check before HW resource destory.

Signed-off-by: Prike Liang <Prike.Liang@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Huang Rui <ray.huang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

index 6447cd6..7ecc6e4 100644 (file)
@@ -2678,7 +2678,7 @@ static int amdgpu_device_ip_suspend_phase1(struct amdgpu_device *adev)
 {
        int i, r;
 
-       if (adev->in_poweroff_reboot_com ||
+       if (adev->in_poweroff_reboot_com || adev->in_hibernate ||
            !amdgpu_acpi_is_s0ix_supported(adev) || amdgpu_in_reset(adev)) {
                amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE);
                amdgpu_device_set_cg_state(adev, AMD_CG_STATE_UNGATE);
@@ -3742,7 +3742,11 @@ int amdgpu_device_suspend(struct drm_device *dev, bool fbcon)
 
        amdgpu_fence_driver_suspend(adev);
 
-       if (adev->in_poweroff_reboot_com ||
+       /*
+        * TODO: Need figure out the each GNB IP idle off dependency and then
+        * improve the AMDGPU suspend/resume sequence for system-wide Sx entry/exit.
+        */
+       if (adev->in_poweroff_reboot_com || adev->in_hibernate ||
            !amdgpu_acpi_is_s0ix_supported(adev) || amdgpu_in_reset(adev))
                r = amdgpu_device_ip_suspend_phase2(adev);
        else