insane: improve diagnostic for redundant rpath
authorPhil Blundell <philb@gnu.org>
Fri, 15 Jul 2011 11:19:35 +0000 (12:19 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 20 Jul 2011 21:20:28 +0000 (22:20 +0100)
Make it more obvious which file, and which recipe, are at issue.

(From OE-Core rev: 207a2176bdebe217daf81d5c5b1d2ab4ab2e6adc)

Signed-off-by: Phil Blundell <philb@gnu.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/insane.bbclass

index c45f2cb..65eda9e 100644 (file)
@@ -142,7 +142,7 @@ def package_qa_check_rpath(file,name, d, elf, messages):
                 messages.append("package %s contains bad RPATH %s in file %s" % (name, line, file))
 
 QAPATHTEST[useless-rpaths] = "package_qa_check_useless_rpaths"
-def package_qa_check_useless_rpaths(file,name, d, elf, messages):
+def package_qa_check_useless_rpaths(file, name, d, elf, messages):
     """
     Check for RPATHs that are useless but not dangerous
     """
@@ -164,7 +164,7 @@ def package_qa_check_useless_rpaths(file,name, d, elf, messages):
           if rpath == libdir or rpath == base_libdir:
              # The dynamic linker searches both these places anyway.  There is no point in
              # looking there again.
-             messages.append("dynamic section contains probably-redundant RPATH %s" % rpath)
+             messages.append("%s: %s contains probably-redundant RPATH %s" % (name, package_qa_clean_path(file, d), rpath))
 
 QAPATHTEST[dev-so] = "package_qa_check_dev"
 def package_qa_check_dev(path, name, d, elf, messages):